Comments about JunkDump

Comment #12

no-reply@curseforge.com (mkosan) — Tue, 07 Oct 2008 07:02:45 +0000

That someone would be me, and I'm very grateful :) also I'm very happy that you put in option to sell all profession junk regardless of rarity - finally I can sell all damn seeds and junk with one click of a button. All works like a charm xD Thanks fro that time-saving addon :)

... I'm going to drop another suggestion *hides*

Comment #11

no-reply@curseforge.com (Daegalus) — Tue, 07 Oct 2008 00:06:41 +0000

Awesome, didn't think of that. Thanks for the code. I will add it into the next release and put you in the credits. Already tested, and works great.

Also don't worry about it, unless you downloaded 1.0rc4 as your first release, then you are fine. Right-click on Sell Junk to open Options was a 1.0rc4 addition based on a ticket suggestion someone put up. I also posted that message as 1.0rc4 was being packaged by the packager. So unless 1.0rc4 was your first version and thats when you looked at the page, you wouldn't of seen it, or known of the feature, since it didn't exist yet.

Comment #10

no-reply@curseforge.com (phliptrip) — Mon, 06 Oct 2008 15:00:32 +0000

I hadn't realized you could right click on the button to get the options screen, so I started to dig around for a way to add a button to the interface to open the options screen (/facepalm) once I realized you already did this I figured I'd add a tooltip for other idiots like myself who don't pay attention to the notes on the addons page after the first time they install.

JunkDump.lua - Put this function in JunkDump.lua

function JunkDump.OnMouseOverButton()
	Tooltips.CreateTextOnlyTooltip("JunkDumpButtonWin") 
	Tooltips.SetTooltipText(1, 1, L"Left Click - Sell Junk")
	Tooltips.SetTooltipText(2, 1, L"Right Click - Options Window")
	Tooltips.Finalize()
	Tooltips.AnchorTooltip(Tooltips.ANCHOR_WINDOW_LEFT)
end

JunkDump.xml - Add this to the eventhandlers section:

<EventHandler event="OnMouseOver" function="JunkDump.OnMouseOverButton" />

I'd have posted this as a patch in the ticket section, but it doesn't seem to accept uploads or any kind of markup to make it not evaluate the code if you paste it. Maybe I just don't understand the way its setup. *shrug*.

Comment #9

no-reply@curseforge.com (Kanedacorp) — Tue, 30 Sep 2008 13:36:21 +0000

Have a look at the code in my sendstuff addon, it is based on junkdump so you should have no trouble figuring out the flow ;) I've got code in there that picks out the different tradeskill items.

oh btw, in the latest version of junkdump it is giving a script call failed line 280: bad argument #1 to match (wstring expected, got string.)

Comment #8

no-reply@curseforge.com (Daegalus) — Tue, 30 Sep 2008 00:04:27 +0000

I just didn't know how to distinguish them by type. I looked at the files but I couldn't figure it out. If you could enlighten me on this. I would greatly appreciate it.

Comment #7

no-reply@curseforge.com (Felyza) — Mon, 29 Sep 2008 19:41:42 +0000

Would be nice to get configurable by type. Such as sell all cultivating or salvaging items, keep all apothecary items. As a thought on this, see the CraftingItemType. If this were implemented, for salvagers, would need to also know if EITEMFLAG_MUNDANE_SALVAGABLE is set on items to ensure they don't autosell items that they could salvage. Regarding potions, you could check ItemTypes for POTION (31), to prevent potions from going. =)

Comment #2

no-reply@curseforge.com (Daegalus) — Sat, 23 Aug 2008 05:22:37 +0000

There is a new version comming out real soon, it will fix all those problems. Up until now most of it was coded blind with Aiiane running it, but nothing beats personally debugging it. huge amount of fixes comming out in next release. hold tight.

Comment #1

no-reply@curseforge.com (trfic1) — Fri, 22 Aug 2008 16:57:08 +0000

This add on nuked my chat windows when I had it loaded. Couldn't use slash command, couldn't see chat or combat. Realize it is not "polished" yet, but does make the tool quite useless atm.