3 - insertion into list
It seems there is a logic flaw when inserting members into the list. it's quite late now, so i can't play with it some more atm.
I've checked that the right number of members are found for the group. the sorted list usually only slows one member though. So either members get overwritten or not added after the first one.
Furthermore there seems to be a flaw with the ignorelist, as the istargetvalid never seems to be called (or another problem in the nesting loop is causing it).
No obvious code flaws or exceptions. Idchecking and setting works; maybe include the small list from my comments in the help file?
| User | When | Change |
|---|---|---|
| oyzyu | Mon, 15 Sep 2008 22:15:20 | Create |
- 2 comments
- 2 comments
Facts
- Reported on
- 15 Sep 2008
- Status
- New - Issue has not had initial review yet.
- Type
- Defect - A shortcoming, fault, or imperfection
- Priority
- Medium - Normal priority.
Reported by
Possible assignees
-
- Manager
- Author
- #2
khalid_war Mon, 15 Sep 2008 22:55:48Okay, I noticed two problems in the insertion to list after I read your ticket.
For one, it was treating 0 health players as valid to put on the list, which is bad, so I fixed that.
It also had a check that was doing weird things. I cleaned up the code in inserttoheathlist and handran some examples. It looks like that function should be good to go now(hopefully).
I uploaded the new version as v1.311unstable
- #1
khalid_war Mon, 15 Sep 2008 22:35:11I noticed right after Aiiane approved the first version I had just put up that I had a problem in the Ignorelist check, in fact it was doing exactly the opposite of what it was supposd to do. I uploaded a fix but not sure if you got it before you tested, that might have been the problem.
Anyway, much appreciated you looking into this.