4 - 1.331 some remarks
there is a small type near line 124, where the if statement is not formatted correctly. minor issue and solved (forgot "then" and "end" statement)
The main problem comes with the repeat-until in the target selection. It's the main reason why is use a front-loaded "while" and an exception statement in my version. The problem is that it doesn't allow for a 0-length list. The condition will happen when auto-running the monitor and the player dies. list length is now 0 and the repeat will put the client into endless loop (unfortunately the client doesn't catch this, I've manually verified this several times now :) ). I'd suggest using "<" instead of "==" or a while-loop.
if you use:
while (idx < EMonitor.SortedSize )
...
end
and both are 0 it will skip the loop entirely. If you do your exception flag after this you can target 'self'. "repeat" will run at least once which is undesirable with an empty list
| User | When | Change |
|---|---|---|
| oyzyu | Tue, 16 Sep 2008 12:52:09 | Create |
- 1 comment
- 1 comment
Facts
- Reported on
- 16 Sep 2008
- Status
- New - Issue has not had initial review yet.
- Type
- Defect - A shortcoming, fault, or imperfection
- Priority
- Medium - Normal priority.
- #1
oyzyu Tue, 16 Sep 2008 13:23:31some more typos on lines 145-148 > Emonitor iso EMonitor. with the ignorelist disabled it works, although it seems more fidly with regards to range checking than my version? might be because i monitor more triggers for my updatelist. the ignorelist seems to create quite a bit of lag overhhead/ not tested it because of it